Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation complete #176

Merged
merged 4 commits into from
May 14, 2024
Merged

French translation complete #176

merged 4 commits into from
May 14, 2024

Conversation

idrista
Copy link
Contributor

@idrista idrista commented May 5, 2024

Given that the PR #16 hasn't been updated in 6 years, I took the initiative of making a French version available to the community.

I've included the work of @olivierlacan (His commits were squashed into one.) by making some corrections and adding all the missing translations.

The translation is now complete, I hope it will be useful to French learners.

@hmdne
Copy link
Collaborator

hmdne commented May 14, 2024

Great work! One little suggestion - you should also add the language here:

https://github.com/ruby/TryRuby/blob/master/app/try_ruby.rb#L108

@idrista
Copy link
Contributor Author

idrista commented May 14, 2024

Great work! One little suggestion - you should also add the language here:

https://github.com/ruby/TryRuby/blob/master/app/try_ruby.rb#L108

Nice comment, thanks for this review

@hmdne hmdne merged commit 8b3793c into ruby:master May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants