Migrate org groups (hr_group -> admin_group, primary_group -> member_group)

[simensandhaug]

Changes

• Change DB fields for hr_group and primary_group to admin_group and member_group for organizations
• Change name and group type for all responsible groups
• New ResponsibleGroup.name format "Organization:Type" instead of just "Type"
• ResponsibleGroup.group_type format "Type" (e.g ADMIN or MEMBER)
• Every ResponsibleGroup also has a pointer to a Group object that has outdated names
  • Previous : "Organization:(HR|Medlem):uuid"
  • New : "Organization:(Admin|Member):uuid"
• These changes make it easier to navigate api.indokntnu.no/admin and the names are more descriptive
• Change necessary instances of hr_group and primary_group

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
indok-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 27, 2023 at 4:24PM (UTC)

[larwaa]

Absolutely fantastic job with this PR. A migration such as this always introduces a lot of complexity, and I think you've handled it in an excellent manner! Have a look at the feedback on migrations which I think will make your life a bit easier, and the other comments that I hope you find useful 😊 Again, great work with this, you're really touching some of the more complex parts of the application 🏆

[codecov]

Codecov Report

Merging #1275 (6a8a60e) into main (4d8fa0d) will decrease coverage by 0.01%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main    #1275      +/-   ##
==========================================
- Coverage   81.55%   81.54%   -0.01%     
==========================================
  Files          88       88              
  Lines        3166     3165       -1     
==========================================
- Hits         2582     2581       -1     
  Misses        584      584              

Flag	Coverage Δ
apitests	81.54% <94.11%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
backend/apps/organizations/signals.py	79.41% <75.00%> (ø)
backend/apps/forms/signals.py	100.00% <100.00%> (ø)
backend/apps/organizations/models.py	85.00% <100.00%> (ø)
backend/apps/organizations/types.py	73.77% <100.00%> (ø)
backend/apps/permissions/constants.py	100.00% <100.00%> (ø)
backend/apps/permissions/signals.py	97.50% <100.00%> (-0.07%)	⬇️
backend/apps/events/resolvers.py	20.43% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

fixed the requested changes

[larwaa]

These are always a bit tricky, lots of moving parts, but I think it's more or less good to go, just a minor bug

[simensandhaug]

Requested changes should be fixed if i understood the problem with uuid correctly. If not im positive we can just remove the uuid from the name altogether, i cant see a reason why we would specifically need it in the name on the adminpage because it would be a field?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication