Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core module pr patch #215

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Core module pr patch #215

merged 1 commit into from
Oct 10, 2023

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Oct 10, 2023

Description

Removed workspaceEnabled$ from workspace service module, a followup PR will create to implement the flag within capabilities service

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Update test description per comment

Co-authored-by: Miki <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl ruanyl force-pushed the core-module-pr-patch branch from d0413bd to 3d5a042 Compare October 10, 2023 04:13
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #215 (3d5a042) into workspace-pr-integr (c05b434) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #215      +/-   ##
=======================================================
- Coverage                66.46%   66.46%   -0.01%     
=======================================================
  Files                     3408     3408              
  Lines                    65222    65219       -3     
  Branches                 10457    10457              
=======================================================
- Hits                     43353    43349       -4     
  Misses                   19265    19265              
- Partials                  2604     2605       +1     
Flag Coverage Δ
Linux_ 66.04% <ø> (-0.01%) ⬇️
_1 34.82% <ø> (+<0.01%) ⬆️
_2 55.45% <ø> (-0.01%) ⬇️
_3 44.49% <ø> (+<0.01%) ⬆️
_4 34.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lication/capabilities/capabilities_service.mock.ts 100.00% <ø> (ø)
...c/core/public/workspace/workspaces_service.mock.ts 100.00% <ø> (ø)
src/core/public/workspace/workspaces_service.ts 88.88% <ø> (-1.12%) ⬇️
...e/server/capabilities/capabilities_service.mock.ts 75.00% <ø> (ø)
...c/core/server/capabilities/capabilities_service.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wanglam
Copy link
Collaborator

wanglam commented Oct 10, 2023

@ruanyl Is there any examples about how to use this flag in the capabilities service?

@ruanyl
Copy link
Owner Author

ruanyl commented Oct 10, 2023

@ruanyl Is there any examples about how to use this flag in the capabilities service?

You mean how to use capabilities service? You can find an example in src/plugins/management/server/plugin.ts

@ruanyl ruanyl merged commit 903e594 into workspace-pr-integr Oct 10, 2023
62 of 63 checks passed
ruanyl added a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants