add permission check for bulkCreate when overwrite #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanglam
reviewed
Sep 22, 2023
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## workspace #198 +/- ##
==========================================
Coverage 66.21% 66.22%
==========================================
Files 3420 3420
Lines 65755 65755
Branches 10589 10589
==========================================
+ Hits 43541 43543 +2
+ Misses 19577 19570 -7
- Partials 2637 2642 +5
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanyl
reviewed
Sep 25, 2023
| if (options?.workspaces && options.workspaces.length > 0) { | ||
| const permitted = await this.validateMultiWorkspacesPermissions( | ||
| options.workspaces, | ||
| const isPassedWorkspaces = options?.workspaces && options.workspaces.length > 0; |
There was a problem hiding this comment.
Nit: rename isPassedWorkspaces -> hasTargetWorkspaces
| !(await this.validateMultiWorkspacesPermissions( | ||
| options.workspaces, | ||
| options.workspaces!, |
There was a problem hiding this comment.
Let's avoid using non-null assertion, you could do options.workspaces ?? [] instead.
wanglam
reviewed
Oct 9, 2023
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
wanglam
approved these changes
Oct 9, 2023
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
raintygao
force-pushed
the
feat-create-overwrite-permission
branch
from
6f09358 to
32eb7ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add permission check for bulkCreate when overwrite
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr