Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [email protected] deprecation errors and enhance security checks #277

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

Utsav-Ladani
Copy link
Contributor

Fix [email protected] deprecation errors and enhance security checks

Fix [email protected] deprecation errors

  • Replace FILTER_SANITIZE_STRING with FILTER_SANITIZE_FULL_SPECIAL_CHARS.

Enhance security checks

  • Change escaping functions esc_attr to esc_html and vise-versa on required places.
  • Replace current_user_can( 'administrator' ) with current_user_can( 'manage_options' ) because there is not such capability with the name administrator.

Related issues

Replace FILTER_SANITIZE_STRING with FILTER_SANITIZE_FULL_SPECIAL_CHARS. Change escaping functions. Correct 'user is admin1' check.

Closes: 275
Copy link

@vishalkakadiya vishalkakadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor feedback, LGTM!

admin/rt-retranscode-admin.php Show resolved Hide resolved
@Utsav-Ladani Utsav-Ladani merged commit ced3d8a into develop Oct 18, 2023
2 of 3 checks passed
@Utsav-Ladani Utsav-Ladani deleted the fix/PHP-deprecation-error branch October 18, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants