Skip to content

Commit

Permalink
Convert bindAll to an async function (#3904)
Browse files Browse the repository at this point in the history
Co-authored-by: Carson <[email protected]>
Co-authored-by: cpsievert <[email protected]>
  • Loading branch information
3 people authored Oct 24, 2023
1 parent c4ef423 commit 81bdde6
Show file tree
Hide file tree
Showing 22 changed files with 3,745 additions and 2,298 deletions.
9 changes: 9 additions & 0 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ parser: '@typescript-eslint/parser'
parserOptions:
ecmaVersion: 2018
sourceType: module
project:
- './tsconfig.json'
ignorePatterns: # mirrors tsconfig.json's exclude
- '**/__tests__'
- '**/*.d.ts'
plugins:
- '@typescript-eslint'
- prettier
Expand Down Expand Up @@ -70,6 +75,10 @@ rules:

"@typescript-eslint/consistent-type-imports":
- error

"@typescript-eslint/no-floating-promises":
- error

"@typescript-eslint/naming-convention":
- error

Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# shiny (development version)

## Possibly breaking changes

* Closed #3899: The JS functions `Shiny.renderContent()` and `Shiny.bindAll()` are now asynchronous. These changes were motivated by the recent push toward making dynamic UI rendering asynchronous (and should've happened when it was first introduced in Shiny v1.7.5). The vast majority of user code using these functions should continue to work as before, but some code may break if it relies on these functions being synchronous (i.e., blocking downstream operations until completion). In this case, consider `await`-ing the downstream operations (or placing in a `.then()` callback). (#3929)

## New features and improvements

* Updated `selectizeInput()`'s selectize.js dependency from v0.12.4 to v0.15.2. In addition to many bug fixes and improvements, this update also adds several new [plugin options](https://selectize.dev/docs/demos/plugins). (#3875)
Expand Down
Loading

0 comments on commit 81bdde6

Please sign in to comment.