Fix CPTR_EL3 to match raspberrypi/tools#123 #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While researching ARM register settings used in Circle, I noticed that RES0 bits were being set to 1 in
CPTR_EL3. After comparing with raspberry pi official stub, I noticed this is something that was reported and fixed after the circle version was forked.It looks like there may also be a couple of other fixes in armstub8.S upstream, but I haven't looked into too much detail. This seemed like a relatively isolated fix. I also haven't checked if there are fixed in the 32 bit stub since the fork.
See raspberrypi/tools#123 for the upstream fix.