Merge pull request #575 from rspec/sub-process-binary

Prevent warnings about encoding from preventing transfer of errors
rspec · Apr 18, 2023 · 6d33eaa · 6d33eaa
2 parents f5cf0d5 + 8f165d8
commit 6d33eaa
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lib/rspec/support/spec/in_sub_process.rb b/lib/rspec/support/spec/in_sub_process.rb
@@ -11,6 +11,10 @@ def in_sub_process(prevent_warnings=true) # rubocop:disable Metrics/MethodLength
           exception_reader, exception_writer = IO.pipe
           result_reader, result_writer = IO.pipe
 
+          # Set binary mode to avoid errors surrounding ascii-8bit to utf-8 conversion
+          # this happens with warnings on rspec-rails for example
+          [exception_reader, exception_writer, result_reader, result_writer].each { |io| io.binmode }
+
           pid = Process.fork do
             warning_preventer = $stderr = RSpec::Support::StdErrSplitter.new($stderr)