Add code review feedback, this feat works only ruby version > 1.8.7

rspec · May 25, 2024 · 4c22e70 · 4c22e70
1 parent b993756
commit 4c22e70
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 17 deletions.
diff --git a/lib/rspec/support/differ.rb b/lib/rspec/support/differ.rb
@@ -19,7 +19,7 @@ def diff(actual, expected)
               diff = diff_as_string(coerce_to_string(actual), coerce_to_string(expected))
             end
           elsif no_procs_and_no_numbers?(actual, expected)
-            if Hash === expected && hash_with_anything?(expected)
+            if (RUBY_VERSION.to_f > 1.8) && hash_with_anything?(expected)
               diff = diff_as_object_with_anything(actual, expected)
             else
               diff = diff_as_object(actual, expected)
@@ -85,7 +85,7 @@ def initialize(opts={})
     private
 
       def hash_with_anything?(arg)
-        safely_flatten(arg).any? { |a| RSpec::Mocks::ArgumentMatchers::AnyArgMatcher === a }
+        Hash === arg && safely_flatten(arg).any? { |a| RSpec::Mocks::ArgumentMatchers::AnyArgMatcher === a }
       end
 
       def no_procs_and_no_numbers?(*args)

diff --git a/spec/rspec/support/differ_spec.rb b/spec/rspec/support/differ_spec.rb
@@ -556,21 +556,24 @@ def inspect; "<BrokenObject>"; end
           end
         end
 
-        describe "fuzzy matcher anything" do
-          it "outputs only key value pair that triggered diff, anything_key should absorb actual value" do
-            actual = { :fixed => "fixed", :trigger => "trigger", :anything_key => "bcdd0399-1cfe-4de1-a481-ca6b17d41ed8" }
-            expected = { :fixed => "fixed", :trigger => "wrong", :anything_key => anything }
-            diff = differ.diff(actual, expected)
-            expected_diff = dedent(<<-'EOD')
-              |
-              |@@ -1,4 +1,4 @@
-              | :anything_key => "bcdd0399-1cfe-4de1-a481-ca6b17d41ed8",
-              | :fixed => "fixed",
-              |-:trigger => "wrong",
-              |+:trigger => "trigger",
-              |
-            EOD
-            expect(diff).to be_diffed_as(expected_diff)
+        unless RUBY_VERSION == '1.8.7'
+          describe "fuzzy matcher anything" do
+            it "outputs only key value pair that triggered diff, anything_key should absorb actual value" do
+              actual = { :fixed => "fixed", :trigger => "trigger", :anything_key => "bcdd0399-1cfe-4de1-a481-ca6b17d41ed8" }
+              expected = { :fixed => "fixed", :trigger => "wrong", :anything_key => anything }
+              diff = differ.diff(actual, expected)
+              expected_diff = dedent(<<-'EOD')
+                |
+                |@@ -1,4 +1,4 @@
+                | :anything_key => "bcdd0399-1cfe-4de1-a481-ca6b17d41ed8",
+                | :fixed => "fixed",
+                |-:trigger => "wrong",
+                |+:trigger => "trigger",
+                |
+              EOD
+              # puts diff
+              expect(diff).to be_diffed_as(expected_diff)
+            end
           end
         end
       end