Fixed processor dispose race condition (#135)

rsocket · Dec 26, 2024 · 8065699 · 8065699
1 parent 6a82fb1
commit 8065699
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/socket/duplex.go b/internal/socket/duplex.go
@@ -256,11 +256,13 @@ func (dc *DuplexConnection) RequestResponse(req payload.Payload) (res mono.Mono)
 
 	onFinally := func(s reactor.SignalType, d reactor.Disposable) {
 		common.TryRelease(handler.cache)
-		d.Dispose()
 		if s == reactor.SignalTypeCancel {
 			dc.sendFrame(framing.NewWriteableCancelFrame(sid))
 		}
+		// Unregister handler w/sink (processor).
 		dc.unregister(sid)
+		// Dispose sink (processor).
+		d.Dispose()
 	}
 
 	m, s, _ := mono.NewProcessor(dc.reqSche, onFinally)