-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable swift package manager #63
base: master
Are you sure you want to change the base?
Changes from 8 commits
93e4739
81b7a78
b0113bc
4a40586
a27d471
e513afe
7fd906e
a90fd43
79a781a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
name: Swift | ||
|
||
on: | ||
push: | ||
branches: [ develop ] | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: macos-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Build | ||
run: swift build -v | ||
- name: Run tests | ||
run: swift test -v |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,17 @@ | |
*.diff | ||
|
||
xcuserdata | ||
|
||
# Created by https://www.toptal.com/developers/gitignore/api/swiftpm | ||
# Edit at https://www.toptal.com/developers/gitignore?templates=swiftpm | ||
|
||
### SwiftPM ### | ||
Packages | ||
.build/ | ||
xcuserdata | ||
DerivedData/ | ||
*.xcodeproj | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be what's breaking the project. If I'm not mistaken, the standard Xcode project is going to get nuked by this. I'd like peertalk when simply checking out the code, opening Xcode and hitting "Build and Run". Let's work out a way so that, and Swift PM can live side by side (if possible, if not, let's discuss). |
||
|
||
|
||
# End of https://www.toptal.com/developers/gitignore/api/swiftpm | ||
.swiftpm |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// swift-tools-version:5.3 | ||
// The swift-tools-version declares the minimum version of Swift required to build this package. | ||
// | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included in | ||
// all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
// THE SOFTWARE. | ||
|
||
import PackageDescription | ||
|
||
let package = Package( | ||
name: "Peertalk", | ||
platforms: [ | ||
.macOS(.v10_15), | ||
.iOS(.v14) | ||
], | ||
products: [ | ||
// Products define the executables and libraries a package produces, and make them visible to other packages. | ||
.library( | ||
name: "Peertalk", | ||
targets: ["Peertalk"]), | ||
], | ||
dependencies: [ | ||
// Dependencies declare other packages that this package depends on. | ||
// .package(url: /* package url */, from: "1.0.0"), | ||
], | ||
targets: [ | ||
// Targets are the basic building blocks of a package. A target can define a module or a test suite. | ||
// Targets can depend on other targets in this package, and on products in packages this package depends on. | ||
.target( | ||
name: "Peertalk", | ||
dependencies: [], | ||
exclude: [ | ||
"Info.plist" | ||
], | ||
publicHeadersPath: ""), | ||
.testTarget( | ||
name: "PeertalkTests", | ||
dependencies: ["Peertalk"], | ||
exclude: [ | ||
"Info.plist" | ||
] | ||
) | ||
] | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ Pod::Spec.new do |spec| | |
spec.summary = 'iOS and OS X Cocoa library for communicating over USB and TCP.' | ||
|
||
spec.source = { :git => "https://github.com/rsms/PeerTalk.git", :tag => '0.1.0' } | ||
spec.source_files = 'peertalk/*.{h,m}' | ||
spec.source_files = 'Sources/peertalk/*.{h,m}' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Happy for this change of location, seems like an improvement to the project structure. |
||
spec.ios.deployment_target = '14.0' | ||
spec.osx.deployment_target = '11.0' | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
#import "PTChannel.h" | ||
#import "PTPrivate.h" | ||
#import "include/PTChannel.h" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this a necessary change to make things work with Swift PM? If no then, can we keep the scope of this change to adding Swift PM and not moving these headers out too? |
||
#import "include/PTPrivate.h" | ||
|
||
#include <sys/ioctl.h> | ||
#include <sys/un.h> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,9 +7,9 @@ | |
#import <netinet/in.h> | ||
#import <sys/socket.h> | ||
|
||
#import <peertalk/PTProtocol.h> | ||
#import <peertalk/PTUSBHub.h> | ||
#import <peertalk/PTDefines.h> | ||
#import "PTProtocol.h" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't seem right to me. Xcode already allows you to |
||
#import "PTUSBHub.h" | ||
#import "PTDefines.h" | ||
|
||
@class PTAddress; | ||
@protocol PTChannelDelegate; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a test for the build is fantastic, thank you.