Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a Swift package #56

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tonyarnold
Copy link

This PR introduces a Swift Package Manager compatible package definition, so that Peertalk can be included as a dependency by SPM projects, and natively within Xcode 11 and more recent releases.

This resolves a static analysis warning about the value stored to `error` never being read, and following uses seem to indicate this individual case might be a typo.
@hughbe
Copy link

hughbe commented Jan 12, 2021

Yes please!!

@sieren
Copy link

sieren commented Mar 7, 2021

Can this get merged please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants