Improving integration test, fixing non-exhaustive switch and adding t…

…est for that
rqlite · Nov 6, 2024 · 87fd7ba · 87fd7ba
1 parent 7f211cc
commit 87fd7ba
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/RqliteDotnet.IntegrationTest/RqliteClientTests.cs b/RqliteDotnet.IntegrationTest/RqliteClientTests.cs
@@ -1,3 +1,4 @@
+using System.Text.RegularExpressions;
 using DotNet.Testcontainers.Builders;
 using NUnit.Framework;
 
@@ -24,5 +25,6 @@ public async Task RqliteClientPing_Works()
         var version = await client.Ping();
 
         Assert.That(version, Is.Not.Empty);
+        Assert.That(Regex.IsMatch(version, @"v\d+.\d+.+")); //v8.10.1
     }
 }
diff --git a/RqliteDotnet.Test/UrlBuilderTests.cs b/RqliteDotnet.Test/UrlBuilderTests.cs
@@ -1,3 +1,4 @@
+using System;
 using NUnit.Framework;
 
 namespace RqliteDotnet.Test;
@@ -25,4 +26,12 @@ public void UrlBuilder_BuildsCorrectUrlWithReadLevel()
         Assert.That(url.StartsWith(baseUrl));
         Assert.That(url, Is.EqualTo("/db/query?timings&q=select%20%2A%20from%20foo&level=strong"));
     }
+
+    [Test]
+    public void UrlBuilder_ThrowsWhenIncorrectReadLevelSupplied()
+    {
+        var query = "select * from foo";
+        var baseUrl = "/db/query?timings";
+        Assert.Throws<ArgumentException>(() => UrlBuilder.Build(baseUrl, query, (ReadLevel)0));
+    }
 }
diff --git a/RqliteDotnet/UrlBuilder.cs b/RqliteDotnet/UrlBuilder.cs
@@ -19,7 +19,8 @@ private static string GetReadLevel(ReadLevel level)
             ReadLevel.Linearizable => "&level=linearizable",
             ReadLevel.Strong => "&level=strong",
             ReadLevel.None => "&level=none",
-            ReadLevel.Auto => "&level=auto"
+            ReadLevel.Auto => "&level=auto",
+            _ => throw new ArgumentException("Unknown read level")
         };
         return result;
     }