Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (Airdrops): Optional icon_path #53

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix (Airdrops): Optional icon_path #53

merged 1 commit into from
Feb 14, 2024

Conversation

OjusWiZard
Copy link
Contributor

@OjusWiZard OjusWiZard commented Feb 14, 2024 •
edited
Loading

  • Add icon_path as an optional field

@OjusWiZard OjusWiZard force-pushed the feat/airdrop branch 2 times, most recently from 163d002 to 0e97afc Compare February 14, 2024 16:49
yabirgb
yabirgb reviewed Feb 14, 2024
View reviewed changes
tests/test_airdrops.py Outdated Show resolved Hide resolved
yabirgb
yabirgb approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@yabirgb yabirgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yabirgb yabirgb merged commit cbd63da into rotki:develop Feb 14, 2024
2 checks passed
@OjusWiZard OjusWiZard deleted the feat/airdrop branch February 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yabirgb yabirgb yabirgb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OjusWiZard @yabirgb