Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated linter and .clang-format for ROS2 #412

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

bsutherland333
Copy link
Contributor

@bsutherland333 bsutherland333 commented Dec 15, 2023

Some of the style guidelines have changed for ROS2, and since we want to keep a consistent style throughout ROSflight, I'm updating the firmware as well.

Lately, the existing format linter has also been disagreeing with the changes made by the fix_code_style.sh script, which has been pretty annoying. So this updates the action item to use a newer version as well, fixing the issue.

@bsutherland333 bsutherland333 force-pushed the clang-tidy-linter-updates branch from a0fd999 to f3dd157 Compare December 15, 2023 17:37
@bsutherland333 bsutherland333 marked this pull request as ready for review December 15, 2023 17:44
@bsutherland333 bsutherland333 self-assigned this Dec 15, 2023
@bsutherland333 bsutherland333 force-pushed the clang-tidy-linter-updates branch from 71952b4 to b071e7c Compare December 15, 2023 19:37
@bsutherland333
Copy link
Contributor Author

F1 and F4 builds are currently broken, but are going to be removed shortly and replaced with a working build.

@bsutherland333 bsutherland333 merged commit 11e8c0a into main Dec 15, 2023
2 of 4 checks passed
@bsutherland333 bsutherland333 deleted the clang-tidy-linter-updates branch December 15, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants