Fix seg.Remove Swallowing Error (#38)

rosedblabs · Jun 18, 2024 · cce2a07 · cce2a07
1 parent dea4745
commit cce2a07
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/segment.go b/segment.go
@@ -4,10 +4,11 @@ import (
 	"encoding/binary"
 	"errors"
 	"fmt"
-	"github.com/valyala/bytebufferpool"
 	"hash/crc32"
 	"io"
 	"os"
+
+	"github.com/valyala/bytebufferpool"
 )
 
 type ChunkType = byte
@@ -140,7 +141,9 @@ func (seg *segment) Sync() error {
 func (seg *segment) Remove() error {
 	if !seg.closed {
 		seg.closed = true
-		_ = seg.fd.Close()
+		if err := seg.fd.Close(); err != nil {
+			return err
+		}
 	}
 
 	return os.Remove(seg.fd.Name())