feat: add idl to rosidl spec converter #697
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russkel
force-pushed
the
feature/idl-msgspec
branch
from
77d12a4
to
12cc097
Compare
|
Should this be moved to a separate package? I thought it would make sense to have it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tooling within eProsima's Integration Service ROS2 Handle uses MessageSpecifications to perform code-gen. I have some messages that are IDL format and have added support by using the
rosidl_parseroutput and transforming torosidl_adapterSpecification objects. I was surprised this didn't already exist within the code base so I have created a PR. There isn't a whole lot of code here.Uncertainties that I need help with:
wcharin rosidl? I have added a hack to convert it towstring<=1. I can't help but think this isn't a good solution.long doubletype in rosidl either. I have mapped it to afloat64as a stop gap solution and print a warning, but this probably isn't good enough.TODO: