Load a message/request/goal from standard input #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ymd-stella <[email protected]>
clalancette
requested changes
Aug 2, 2023
Comment on lines
61
to
68
| if args.stdin: | ||
| lines = b"" | ||
| while True: | ||
| line = sys.stdin.buffer.readline() | ||
| if not line: | ||
| break | ||
| lines += line | ||
| args.goal = lines |
There was a problem hiding this comment.
Since we have this exact same stanza in multiple files, I'm going to suggest that we move this into a function in https://github.com/ros2/ros2cli/blob/rolling/ros2cli/ros2cli/helpers.py . That way we'll have less duplicated code. Then this will be something like:
Suggested change
| if args.stdin: | |
| lines = b"" | |
| while True: | |
| line = sys.stdin.buffer.readline() | |
| if not line: | |
| break | |
| lines += line | |
| args.goal = lines | |
| if args.stdin: | |
| arg.goal = utils.collect_stdin() |
clalancette
requested changes
Aug 2, 2023
Signed-off-by: ymd-stella <[email protected]>
ymd-stella
force-pushed
the
feature/stdin
branch
from
1257335
to
0a4196a
Compare
clalancette
approved these changes
Aug 3, 2023
|
CI:
|
clalancette
requested changes
Aug 3, 2023
Signed-off-by: ymd-stella <[email protected]>
|
CI:
|
clalancette
approved these changes
Aug 3, 2023
ymd-stella
added a commit
to ymd-stella/ros2cli
that referenced
this pull request
Aug 4, 2023
* Load a message/request/goal from standard input Signed-off-by: ymd-stella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #842
Add option
--stdinto pass yaml from standard input.The last positional argument and the new option
--stdinare mutually_exclusive_group.The change requires that the send_goal argument
goalbe optional.