Fix linalg error #84
Open
Fix linalg error #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, when we make the rqt_plot window very small, it causes matplotlib to throw an exception like: numpy.linalg.LinAlgError: Singular matrix The trouble seems to be that the matplotlib resize event is trying to invert a zero-sized matrix (I think), so it is giving numpy fits. If one of the dimensions of the windows is 0, just skip trying to apply a tight_layout to it. Signed-off-by: Chris Lalancette <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue that has been fixed in foxy_devel: #73
Running rqt_plot results in an exception:
This PR cherry picks the fix, and has been verified by two users who were encountering the issue.
fyi @iwanders, @mikepurvis, @jasonimercer