Dynamic setting of params in speckle filter #204
+26
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done previously by berend-kupers, but removed during code review because we thought it needed a separate node inside the filter. Here we use the params_interface_ member variable of the filter base class instead of creating a new node. The callback needs to be post_set_params and not on_set_params because the changes haven't been finalized yet when on_set_params is called.
|
Tests fail on humble because the parameter callback interface was different than - there was no separate "post" set params then. We'll need to either branch for humble or use preprocessor conditionals to decide which interface to compile for. I'll take another look at this later in the week. |
|
Builds now, but i want to add a test of the parameter setting before I trust it. |
jonbinney
force-pushed
the
restore-dyn-config
branch
from
eb7708e
to
027b936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done previously by berend-kupers, but removed during code review because we thought it needed a separate node inside the filter. Here we use the params_interface_ member variable of the filter base class instead of creating a new node.
The callback needs to be post_set_params and not on_set_params because the changes haven't been finalized yet when on_set_params is called.