Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use targets when possible for include commands #262

Closed
wants to merge 1 commit into from
Closed

Use targets when possible for include commands #262

wants to merge 1 commit into from

Conversation

RFRIEDM-Trimble
Copy link
Contributor

  • For including directories, use target_include_directories

This is part II of the fixes for #245

@RFRIEDM-Trimble
Use targets when possible
1d698e1 
* For including directories
@RFRIEDM-Trimble RFRIEDM-Trimble changed the title Use targets when possible Use targets when possible for include commands Nov 14, 2022
@gbiggs
Copy link
Contributor

gbiggs commented Nov 24, 2022

Although I see now specific problem with these changes, I do question their value: polled_camera is not built for ROS 2.

@ahcorde
Copy link
Collaborator

ahcorde commented Jul 17, 2023

The polled_camera package is not built in ROS2, there is a COLCON_IGNORE file in the package. Closing this for now

@ahcorde ahcorde closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RFRIEDM-Trimble @gbiggs @ahcorde