Show --- as count if rate limited #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #393 but perhaps a followup should be created to reduce the frequency of github API calls.
The promise chain is partially moved into a function so that the
responsevariable is available. When an error occurs, the counts are replaced with "---". Not sure what the best thing to show here is, perhaps 'ERR" instead? I don't like 'ERR' because it is not really an error, just limits. I don't think it is worth a more prominent error display, as for the vast majority of displays of the repo, people don't really care about the HELP WANTED type counts. But the display of ">99" as at present is confusing and incorrect.