Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple improvements #136

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

mkatliar
Copy link

Several improvements have been made, here are the main ones:

  • RAII-based subscription management
  • Return codes replaced by exception-based error handling in many places
  • Interfaces of RWSClient and RWSInterface made more usable
  • Removed unnecessary class nesting in some places when it makes sense
  • Merged functionality to add/remove modules to tasks
  • Added ZoneData class
  • Using override keyword when appropriate
  • Improved const-correctness

dorianleveque and others added 20 commits November 23, 2020 11:01
commit a61ee60
Author: Mikhail Katliar <[email protected]>
Date:   Fri Jan 22 11:41:37 2021 +0100

    Member functions in RWSClient made const and static where appropriate.

commit 4ffd800
Author: Mikhail Katliar <[email protected]>
Date:   Tue Jan 19 17:19:52 2021 +0100

    - Made RAPIDTaskExecutionState, MechanicalUnitType, and MechanicalUnitMode enum classes;
    - Added value_type in RAPIDAtomicTemplate;

commit cf00d68
Author: Mikhail Katliar <[email protected]>
Date:   Sat Jan 16 15:04:59 2021 +0100

    Moved the Coordinate enum from the RWSClient class scope to the abb::rws namespace scope and made it an enum class. Passing Coordinate by value instead of by reference.

commit 79e5e85
Author: Mikhail Katliar <[email protected]>
Date:   Wed Dec 30 01:36:24 2020 +0100

    * Added cast operator of atomic RAPID types to corresponding standard types.
    * Added override keyword in rws_rapid.h where appropriate.

commit 0aca963
Author: Mikhail Katliar <[email protected]>
Date:   Sat Dec 26 15:29:13 2020 +0100

    Added ZoneData class

commit f0ff994
Author: Mikhail Katliar <[email protected]>
Date:   Sat Dec 26 00:04:30 2020 +0100

    Pulling out nested classes.
…rws namespace scope and made it an enum class. Passing Coordinate by value instead of by reference.
…xception messages from RWSResult and POCOResult.
* Fix file path for loading modules

* Add comment
* RAII-based subscription management
* Exception-based error handling in many places
@mkatliar mkatliar mentioned this pull request Feb 25, 2021
mjd3 added a commit to mjd3/abb_librws that referenced this pull request Aug 3, 2021
Improved API from PR (ros-industrial#136), more python bindings, python packaging
mjd3 added a commit to mjd3/abb_librws that referenced this pull request Aug 11, 2021
@mjd3 mjd3 mentioned this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants