-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple improvements #136
Open
mkatliar
wants to merge
20
commits into
ros-industrial:master
Choose a base branch
from
NoMagicAi:multiple-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit a61ee60 Author: Mikhail Katliar <[email protected]> Date: Fri Jan 22 11:41:37 2021 +0100 Member functions in RWSClient made const and static where appropriate. commit 4ffd800 Author: Mikhail Katliar <[email protected]> Date: Tue Jan 19 17:19:52 2021 +0100 - Made RAPIDTaskExecutionState, MechanicalUnitType, and MechanicalUnitMode enum classes; - Added value_type in RAPIDAtomicTemplate; commit cf00d68 Author: Mikhail Katliar <[email protected]> Date: Sat Jan 16 15:04:59 2021 +0100 Moved the Coordinate enum from the RWSClient class scope to the abb::rws namespace scope and made it an enum class. Passing Coordinate by value instead of by reference. commit 79e5e85 Author: Mikhail Katliar <[email protected]> Date: Wed Dec 30 01:36:24 2020 +0100 * Added cast operator of atomic RAPID types to corresponding standard types. * Added override keyword in rws_rapid.h where appropriate. commit 0aca963 Author: Mikhail Katliar <[email protected]> Date: Sat Dec 26 15:29:13 2020 +0100 Added ZoneData class commit f0ff994 Author: Mikhail Katliar <[email protected]> Date: Sat Dec 26 00:04:30 2020 +0100 Pulling out nested classes.
…rws namespace scope and made it an enum class. Passing Coordinate by value instead of by reference.
…xception messages from RWSResult and POCOResult.
* Fix file path for loading modules * Add comment
* RAII-based subscription management * Exception-based error handling in many places
Closed
mjd3
added a commit
to mjd3/abb_librws
that referenced
this pull request
Aug 3, 2021
Improved API from PR (ros-industrial#136), more python bindings, python packaging
mjd3
added a commit
to mjd3/abb_librws
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements have been made, here are the main ones:
RWSClient
andRWSInterface
made more usableZoneData
classoverride
keyword when appropriate