-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add IRB1600 10/1.45, add opw config for IRB1600 10/1.45, 8/1.45 and 6/1.2 #137
base: kinetic-devel
Are you sure you want to change the base?
add IRB1600 10/1.45, add opw config for IRB1600 10/1.45, 8/1.45 and 6/1.2 #137
Conversation
have you since updated the PR? I don't see this scaling. (if it was there, I would've asked you to scale the
only the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍
I've left one in-line comment. Could you take a look?
Friendly ping @cjue ? |
I just noticed that #136 has introduced the irb1600 8/1.45 in the meantime. Interesting tidbit: the IRB1600 10/1.45 is a re-release / "upgrade" of the IRB1600 8/1.45 that's identical except for payload and velocity limits.
Source: https://search.abb.com/library/Download.aspx?DocumentID=3HAC023604-001&LanguageCode=en& I updated both 1.45 urdfs to use the same link_2 meshes. |
I meant to say this was how I got from the STEP file to the mesh. It's also wrong, as I found out. When comparing my link_2 mesh with the 8/1.45 version I noticed that I had set the origin incorrectly, placing link_2 inside the neighboring joints. This PR now uses the correct mesh for both the 8/1.45 and the 10/1.45.
Yes, the other files already had the model name in there. |
4c41010
to
dd11aa0
Compare
Just a note: This PR does not touch the |
dd11aa0
to
b395be9
Compare
closing and reopening to nudge checks |
also updates reference document in package.xml add mesh for link2, with scale 0.001 and transform -.150, -0.4865, -115
b395be9
to
079c203
Compare
ping addressed @gavanderhoorn |
Update reference document in package.xml
Add mesh for the 1.45 variant of link2, with scale 0.001 and transform -.150, -0.4865, -115
Rename files fo irb1600 6/1.2 for clarity.