Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dt in updateFromVelocity (backport #1481) #1486

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2025

updateFromVelocity is not only called from update but also directly if position_feedback is false so we should also check there is dt is too small


This is an automatic backport of pull request #1481 done by Mergify.

Signed-off-by: Tony Najjar <[email protected]>
(cherry picked from commit 0736e6c)
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.74%. Comparing base (bbb2ff5) to head (61c6fba).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
diff_drive_controller/src/odometry.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1486      +/-   ##
==========================================
- Coverage   66.76%   66.74%   -0.02%     
==========================================
  Files         113      113              
  Lines       13331    13333       +2     
  Branches     8245     8246       +1     
==========================================
- Hits         8900     8899       -1     
- Misses       1437     1438       +1     
- Partials     2994     2996       +2     
Flag Coverage Δ
unittests 66.74% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diff_drive_controller/src/odometry.cpp 43.52% <0.00%> (-1.05%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puh, why this breaks ABI?

Otherwise, good!

@christophfroehlich
Copy link
Contributor

Puh, why this breaks ABI?

good question 🤷‍♂️

@christophfroehlich christophfroehlich merged commit b4d79ab into humble Jan 11, 2025
12 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1481 branch January 11, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants