Use urdf/model.hpp for rolling

[nakul-py]

Description

• Replaced deprecated urdf/model.h with conditional includes using urdf/model.hpp for Rolling.
• Maintained compatibility for Humble and Jazzy using rclcpp/version.h.

Solve #1473 (review)

[saikishor]

Hello @nakul-py

Please also remove these redundant lines from here :

ros2_controllers/joint_state_broadcaster/src/joint_state_broadcaster.cpp

Lines 29 to 34 in 7ddaf83

	#include "rclcpp/version.h"
	#if RCLCPP_VERSION_GTE(29, 0, 0)
	#include "urdf/model.hpp"
	#else
	#include "urdf/model.h"
	#endif

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (7ddaf83) to head (79efce7).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
- Coverage   83.83%   83.82%   -0.01%     
==========================================
  Files         122      122              
  Lines       11120    11120              
  Branches      944      943       -1     
==========================================
- Hits         9322     9321       -1     
- Misses       1489     1490       +1     
  Partials      309      309              

Flag	Coverage Δ
unittests	83.82% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
..._state_broadcaster/src/joint_state_broadcaster.cpp	89.24% <ø> (+0.56%)	⬆️

... and 1 file with indirect coverage changes

[nakul-py]

Hey @saikishor will you also review this pull request #1475

[saikishor]

LGTM

[saikishor]

Hey @saikishor will you also review this pull request #1475

Sure, when I get some time. I'll do it.

[bmagyar]

since it is included in the header with all the version checks, probably better to remove it from here?

Suggested change

#include "urdf/model.h"