Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visibility macros #1451

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Dec 29, 2024

No description provided.

@bmagyar bmagyar marked this pull request as draft December 29, 2024 09:53
@bmagyar bmagyar marked this pull request as ready for review December 29, 2024 10:10
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor comment.
parallel_gripper_controller is missing the set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)

parallel_gripper_controller/CMakeLists.txt Show resolved Hide resolved
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.83%. Comparing base (f23b7d8) to head (da014e9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1451   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files         122      122           
  Lines       11121    11121           
  Branches      945      945           
=======================================
  Hits         9323     9323           
+ Misses       1490     1489    -1     
- Partials      308      309    +1     
Flag Coverage Δ
unittests 83.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...rd_command_controller/forward_controllers_base.hpp 100.00% <ø> (ø)
...jectory_controller/joint_trajectory_controller.hpp 100.00% <ø> (ø)
...include/joint_trajectory_controller/trajectory.hpp 75.00% <ø> (ø)
...nclude/tricycle_controller/tricycle_controller.hpp 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

@bmagyar bmagyar merged commit a1d8da4 into ros-controls:master Dec 30, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants