-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new PoseBroadcaster controller (backport #1311) #1326
Conversation
(cherry picked from commit 7c89c17) # Conflicts: # doc/controllers_index.rst
Cherry-pick of 7c89c17 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
this fails because of API breaks in rolling, I haven't had time to fix that |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1326 +/- ##
========================================
Coverage 65.23% 65.24%
========================================
Files 103 107 +4
Lines 11437 12219 +782
Branches 7254 7536 +282
========================================
+ Hits 7461 7972 +511
- Misses 1483 1561 +78
- Partials 2493 2686 +193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR implements a new broadcasting controller based on the
PoseSensor
semantic component introduced in ros-controls/ros2_control#1775.As described in the
PoseSensor
PR, my primary use-case for this is the publishing of tcp poses from robot arms. This can be more accurate than calculating forward kinematics, as robot calibrations etc. can be considered by the robot. Settings on the robot side concerning tool offsets etc. can also be included by this (at least for UR and kuka RSI). The ROS 1ur_robot_driver
used to publish this transform directly from within the hardware interface, but in ROS 2 there is not yet a standard way for providing this information. A PR for the UR ROS 2 driver already exists at UniversalRobots/Universal_Robots_ROS2_Driver#1108.This controller publishes poses directly as
geometry_msgs::msg::PoseStamped
s and as tf transforms (can be disabled).This is an automatic backport of pull request #1311 done by Mergify.