-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter check for geometric values (backport #1120) #1125
Conversation
Cherry-pick of 7170328 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
b34cb39
to
a724a45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #1125 +/- ##
==========================================
- Coverage 86.91% 86.67% -0.24%
==========================================
Files 86 86
Lines 7595 7483 -112
Branches 620 620
==========================================
- Hits 6601 6486 -115
- Misses 761 762 +1
- Partials 233 235 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Inspired by this post at RSE, I thought it could be a good idea to add simple checks to geometric values of the controllers for mobile robots. For example,
wheel_radius
wheel_base
and others must not be zero ➡️ I added agt<>: [0.0]
validator for them. This also should help if a user misspelled or forgot these parameters.This is an automatic backport of pull request #1120 done by Mergify.