Remove ns from robot_description parameter #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think that the namespace
kinematics
set herehttps://github.com/ros-controls/ros2_controllers/blob/f519170c776649de11431addbfe5bba84ac3603d/admittance_controller/include/admittance_controller/admittance_rule_impl.hpp#L62-L63
should apply to the robot_description parameter, which was introduced with #83.
ns should only apply to the latter parameters, which are defined in the admittance_controller
https://github.com/ros-controls/ros2_controllers/blob/master/admittance_controller/src/admittance_controller_parameters.yaml#L34-L55
Removing fixes ros-controls/ros2_controllers#1354 and does not break the rolling version.