Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visibility boilerplate code #258

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

christophfroehlich
Copy link
Contributor

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (240d29c) to head (791d063).

Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #258   +/-   ##
============================================
  Coverage        72.75%   72.75%           
============================================
  Files               25       25           
  Lines             1101     1101           
  Branches            89       89           
============================================
  Hits               801      801           
  Misses             252      252           
  Partials            48       48           
Flag Coverage Δ
unittests 72.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/control_toolbox/pid.hpp 77.77% <ø> (ø)
include/control_toolbox/pid_ros.hpp 100.00% <ø> (ø)

@christophfroehlich christophfroehlich merged commit 9756cb7 into ros2-master Jan 1, 2025
26 of 28 checks passed
@christophfroehlich christophfroehlich deleted the rm/visibility branch January 1, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants