Fix JRuby specs (closes #16).

ronin-rb · Jan 18, 2024 · 59a7016 · 59a7016
1 parent dfa5f44
commit 59a7016
Show file tree

Hide file tree

Showing 7 changed files with 169 additions and 45 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -7,5 +7,13 @@ inherit_gem:
   rubocop-ronin: rubocop.yml
 
 #
-# ronin-FIXME specific exceptions
+# ronin-support-web specific exceptions
 #
+
+# Need explicit whitespace for the JRuby's specific HTML heredocs.
+Layout/TrailingWhitespace:
+  Exclude:
+    - spec/agent/mixin_spec.rb
+    - spec/agent_spec.rb
+    - spec/html/mixin_spec.rb
+    - spec/html_spec.rb
diff --git a/spec/agent/mixin_spec.rb b/spec/agent/mixin_spec.rb
@@ -179,13 +179,27 @@
         )
 
         doc = subject.web_get_html(uri)
+
         expect(doc).to be_kind_of(Nokogiri::HTML::Document)
-        expect(doc.to_s).to eq(
-          <<~HTML
-            <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
-            #{html.chomp}
-          HTML
-        )
+
+        # XXX: nokogiri's java extensions behave differently from libxml2
+        if RUBY_ENGINE == 'jruby'
+          expect(doc.to_s).to eq(
+            <<~HTML.chomp
+              <html><head></head><body>
+                  <p>hello world</p>
+                
+              </body></html>
+            HTML
+          )
+        else
+          expect(doc.to_s).to eq(
+            <<~HTML
+              <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
+              #{html.chomp}
+            HTML
+          )
+        end
       end
     end
 
@@ -232,8 +246,15 @@
         )
 
         doc = subject.web_get_xml(uri)
+
         expect(doc).to be_kind_of(Nokogiri::XML::Document)
-        expect(doc.to_s).to eq(xml)
+
+        # XXX: nokogiri's java extensions behave differently from libxml2
+        if RUBY_ENGINE == 'jruby'
+          expect(doc.to_s).to eq(xml.chomp)
+        else
+          expect(doc.to_s).to eq(xml)
+        end
       end
     end
 
@@ -454,13 +475,27 @@
         )
 
         doc = subject.web_post_html(uri)
+
         expect(doc).to be_kind_of(Nokogiri::HTML::Document)
-        expect(doc.to_s).to eq(
-          <<~HTML
-            <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
-            #{html.chomp}
-          HTML
-        )
+
+        # XXX: nokogiri's java extensions behave differently from libxml2
+        if RUBY_ENGINE == 'jruby'
+          expect(doc.to_s).to eq(
+            <<~HTML.chomp
+              <html><head></head><body>
+                  <p>hello world</p>
+                
+              </body></html>
+            HTML
+          )
+        else
+          expect(doc.to_s).to eq(
+            <<~HTML
+              <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
+              #{html.chomp}
+            HTML
+          )
+        end
       end
     end
 
@@ -507,8 +542,15 @@
         )
 
         doc = subject.web_post_xml(uri)
+
         expect(doc).to be_kind_of(Nokogiri::XML::Document)
-        expect(doc.to_s).to eq(xml)
+
+        # XXX: nokogiri's java extensions behave differently from libxml2
+        if RUBY_ENGINE == 'jruby'
+          expect(doc.to_s).to eq(xml.chomp)
+        else
+          expect(doc.to_s).to eq(xml)
+        end
       end
     end
 

diff --git a/spec/agent_spec.rb b/spec/agent_spec.rb
@@ -715,13 +715,27 @@
         )
 
         doc = subject.get_html(uri)
+
         expect(doc).to be_kind_of(Nokogiri::HTML::Document)
-        expect(doc.to_s).to eq(
-          <<~HTML
-            <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
-            #{html.chomp}
-          HTML
-        )
+
+        # XXX: nokogiri's java extensions behave differently from libxml2
+        if RUBY_ENGINE == 'jruby'
+          expect(doc.to_s).to eq(
+            <<~HTML.chomp
+              <html><head></head><body>
+                  <p>hello world</p>
+                
+              </body></html>
+            HTML
+          )
+        else
+          expect(doc.to_s).to eq(
+            <<~HTML
+              <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
+              #{html.chomp}
+            HTML
+          )
+        end
       end
     end
 
@@ -768,8 +782,15 @@
         )
 
         doc = subject.get_xml(uri)
+
         expect(doc).to be_kind_of(Nokogiri::XML::Document)
-        expect(doc.to_s).to eq(xml)
+
+        # XXX: nokogiri's java extensions behave differently from libxml2
+        if RUBY_ENGINE == 'jruby'
+          expect(doc.to_s).to eq(xml.chomp)
+        else
+          expect(doc.to_s).to eq(xml)
+        end
       end
     end
 
@@ -1071,13 +1092,27 @@
         )
 
         doc = subject.post_html(uri)
+
         expect(doc).to be_kind_of(Nokogiri::HTML::Document)
-        expect(doc.to_s).to eq(
-          <<~HTML
-            <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
-            #{html.chomp}
-          HTML
-        )
+
+        # XXX: nokogiri's java extensions behave differently from libxml2
+        if RUBY_ENGINE == 'jruby'
+          expect(doc.to_s).to eq(
+            <<~HTML.chomp
+              <html><head></head><body>
+                  <p>hello world</p>
+                
+              </body></html>
+            HTML
+          )
+        else
+          expect(doc.to_s).to eq(
+            <<~HTML
+              <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
+              #{html.chomp}
+            HTML
+          )
+        end
       end
     end
 
@@ -1124,8 +1159,15 @@
         )
 
         doc = subject.post_xml(uri)
+
         expect(doc).to be_kind_of(Nokogiri::XML::Document)
-        expect(doc.to_s).to eq(xml)
+
+        # XXX: nokogiri's java extensions behave differently from libxml2
+        if RUBY_ENGINE == 'jruby'
+          expect(doc.to_s).to eq(xml.chomp)
+        else
+          expect(doc.to_s).to eq(xml)
+        end
       end
     end
 

diff --git a/spec/html/mixin_spec.rb b/spec/html/mixin_spec.rb
@@ -21,9 +21,11 @@
       # XXX: nokogiri's java extensions behave differently from libxml2
       if RUBY_ENGINE == 'jruby'
         expect(doc.to_s).to eq(
-          <<~HTML
-            <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
-            #{html}
+          <<~HTML.chomp
+            <html><head></head><body>
+                <p id="foo">Foo</p>
+              
+            </body></html>
           HTML
         )
       else
@@ -54,9 +56,11 @@
       # XXX: nokogiri's java extensions behave differently from libxml2
       if RUBY_ENGINE == 'jruby'
         expect(doc.to_s).to eq(
-          <<~HTML
-            <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
-            #{html}
+          <<~HTML.chomp
+            <html><head></head><body>
+                <p id="foo">Foo</p>
+              
+            </body></html>
           HTML
         )
       else

diff --git a/spec/html_spec.rb b/spec/html_spec.rb
@@ -15,9 +15,11 @@
       # XXX: nokogiri's java extensions behave differently from libxml2
       if RUBY_ENGINE == 'jruby'
         expect(doc.to_s).to eq(
-          <<~HTML
-            <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
-            #{html}
+          <<~HTML.chomp
+            <html><head></head><body>
+                <p id="foo">Foo</p>
+              
+            </body></html>
           HTML
         )
       else
@@ -48,9 +50,11 @@
       # XXX: nokogiri's java extensions behave differently from libxml2
       if RUBY_ENGINE == 'jruby'
         expect(doc.to_s).to eq(
-          <<~HTML
-            <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
-            #{html}
+          <<~HTML.chomp
+            <html><head></head><body>
+                <p id="foo">Foo</p>
+              
+            </body></html>
           HTML
         )
       else

diff --git a/spec/xml/mixin_spec.rb b/spec/xml/mixin_spec.rb
@@ -17,7 +17,13 @@
       doc = subject.xml_parse(xml)
 
       expect(doc).to be_kind_of(Nokogiri::XML::Document)
-      expect(doc.to_s).to eq(xml)
+
+      # XXX: nokogiri's java extensions behave differently from libxml2
+      if RUBY_ENGINE == 'jruby'
+        expect(doc.to_s).to eq(xml.chomp)
+      else
+        expect(doc.to_s).to eq(xml)
+      end
     end
 
     context "when given a block" do
@@ -34,7 +40,13 @@
       doc = subject.xml_open(xml_file)
 
       expect(doc).to be_kind_of(Nokogiri::XML::Document)
-      expect(doc.to_s).to eq(xml)
+
+      # XXX: nokogiri's java extensions behave differently from libxml2
+      if RUBY_ENGINE == 'jruby'
+        expect(doc.to_s).to eq(xml.chomp)
+      else
+        expect(doc.to_s).to eq(xml)
+      end
     end
 
     context "when given a block" do

diff --git a/spec/xml_spec.rb b/spec/xml_spec.rb
@@ -11,7 +11,13 @@
       doc = subject.parse(xml)
 
       expect(doc).to be_kind_of(Nokogiri::XML::Document)
-      expect(doc.to_s).to eq(xml)
+
+      # XXX: nokogiri's java extensions behave differently from libxml2
+      if RUBY_ENGINE == 'jruby'
+        expect(doc.to_s).to eq(xml.chomp)
+      else
+        expect(doc.to_s).to eq(xml)
+      end
     end
 
     context "when given a block" do
@@ -28,7 +34,13 @@
       doc = subject.open(xml_file)
 
       expect(doc).to be_kind_of(Nokogiri::XML::Document)
-      expect(doc.to_s).to eq(xml)
+
+      # XXX: nokogiri's java extensions behave differently from libxml2
+      if RUBY_ENGINE == 'jruby'
+        expect(doc.to_s).to eq(xml.chomp)
+      else
+        expect(doc.to_s).to eq(xml)
+      end
     end
 
     context "when given a block" do