New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a `Value::WebSocket` class #176

Open

AI-Mozi wants to merge 1 commit into ronin-rb:0.2.0 from AI-Mozi:add_websocket_value

+556 −0

Member

AI-Mozi commented Sep 1, 2024 •

edited

Loading

AI-Mozi added the feature label

AI-Mozi self-assigned this

AI-Mozi force-pushed the add_websocket_value branch 3 times, most recently from 1b0d0bd to 9ad9504 Compare

September 1, 2024 15:51

postmodern requested changes

View reviewed changes

Member

postmodern left a comment

If we're going to be parsing the websocket URIs using URI() we should store the whole URI::WS/URI::WSS object as @uri, similar to Values::URL. This way the URI classes handle the formatting and the various URI fields.

Member Author

AI-Mozi commented Sep 2, 2024

So we should allow to pass only the whole url, not each part separately?

Member

postmodern commented Sep 2, 2024

@AI-Mozi you could probably copy Values::URL. initialize would accept a String or a URI, and you'd have .ws and .wss methods that constructed the URI object based on the input values (might be useful for creating Values::WebSocket objects if nmap somehow detects them).

postmodern mentioned this pull request

Add support for detecting ws:// and wss:// URIs in web/spider #172

Open

AI-Mozi force-pushed the add_websocket_value branch 2 times, most recently from 2a3945b to 635b86d Compare

October 11, 2024 06:44

postmodern requested changes

View reviewed changes

Member

postmodern left a comment

Noticed some things.

lib/ronin/recon/values/web_socket.rb Outdated

+                      #
+                      def self.ws(host,port=80,path=nil,query=nil)
+                        url = "ws://#{host}:#{port}"
+                        url << "#{path}" if path

Member

postmodern Oct 13, 2024

rubocop would probably complain about "#{path}". Just path is better.

lib/ronin/recon/values/web_socket.rb Outdated

+                      #
+                      def self.wss(host,port=443,path=nil,query=nil)
+                        url = "wss://#{host}:#{port}"
+                        url << "#{path}" if path

Member

postmodern Oct 13, 2024

rubocop would probably complain about "#{path}". Just path is better.

lib/ronin/recon/values/web_socket.rb Outdated

+                        url << "#{path}" if path
+                        url << "?#{query}" if query
+                        new(url)

Member

postmodern Oct 13, 2024

It might be easier to just do new(URI::WS.build(host: host, ...)).

lib/ronin/recon/values/web_socket.rb Outdated

+                        url << "#{path}" if path
+                        url << "?#{query}" if query
+                        new(url)

Member

postmodern Oct 13, 2024

It might be easier to just do new(URI::WSS.build(host: host, ...)).

lib/ronin/recon/values/web_socket.rb Outdated

+                      #   The URI object for the website.
+                      #
+                      def to_uri
+                        URI_CLASSES.fetch(scheme).build(host: host, port: port, path: path, query: query)

Member

postmodern Oct 13, 2024

Probably easier to just return @uri to avoid re-creating URIs.

lib/ronin/recon/values/web_socket.rb Outdated

+                      # The parsed URI.
+                      #
+                      # @return [URI::HTTP, URI::HTTPS]

Member

postmodern Oct 13, 2024

s/URI::HTTP/URI::WS/g


          Add a Value::WebSocket class

390675e

AI-Mozi force-pushed the add_websocket_value branch from 635b86d to 390675e Compare

October 24, 2024 06:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature