Add Archive and GitArchive output formats
#173
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI-Mozi
force-pushed
the
add_archive_and_git_archive_output_formats
branch
from
c086226
to
5d844e0
Compare
postmodern
reviewed
Aug 30, 2024
| # | ||
| # Represents a web archive directory. | ||
| # | ||
| class Archive < Ronin::Web::Spider::Archive |
There was a problem hiding this comment.
Sub-classing Ronin::Web::Spider::Archive might cause problems for us in the future if we ever change it's API. Might be safer to initialize it as an ivar in initialize.
| # The path to the root directory. | ||
| # | ||
| def initialize(root) | ||
| super(root) |
There was a problem hiding this comment.
Might be safer to initialize Ronin::Web::Spider::GitArchive as an ivar.
postmodern
reviewed
Sep 1, 2024
AI-Mozi
force-pushed
the
add_archive_and_git_archive_output_formats
branch
from
5d844e0
to
8d62799
Compare
postmodern
requested changes
Sep 6, 2024
| register :png, '.png', PNG | ||
| register :pdf, '.pdf', PDF | ||
| register :web_archive, '', Archive | ||
| register :web_git_archive, '', GitArchive |
There was a problem hiding this comment.
Rename classes to WebArchive and GitArchive.
There was a problem hiding this comment.
The file-exts can be omitted now that they are optional.
| # | ||
| # Represents a web archive directory. | ||
| # | ||
| class Archive |
| # | ||
| # Represents a web archive directory that is backed by Git. | ||
| # | ||
| class GitArchive |
There was a problem hiding this comment.
Rename class to WebGitArchive.
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#146