Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Values::URL#=== method #164

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Add a Values::URL#=== method #164

merged 3 commits into from
Aug 28, 2024

Conversation

AI-Mozi
Copy link
Member

@AI-Mozi AI-Mozi commented Aug 19, 2024

Closing #128

@AI-Mozi AI-Mozi self-assigned this Aug 19, 2024
postmodern
postmodern reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on what other values should be comparable to a URL? Should Host, Domain, Wildcard, etc, be comparable to a URL, or should URLs only be comparable to other URLs? To me URLs represent a specific web page address within a Website/Host/Domain.

lib/ronin/recon/values/url.rb Outdated Show resolved Hide resolved
lib/ronin/recon/values/url.rb Outdated
require 'ronin/recon/values/domain'
require 'ronin/recon/values/website'
require 'ronin/recon/values/wildcard'
require 'ronin/recon/values/host'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be using require_relative now. The main branch has require_relative, and I will probably rebase the 0.2.0 branch today.

@postmodern
Copy link
Member

Hmm, also looks like we have a circular require issue with ronin/recon/values/host and the other ronin/recon/values/ files.

@AI-Mozi AI-Mozi force-pushed the add_values_url_triple_equal branch 3 times, most recently from 9258ea4 to fa39a1e Compare August 26, 2024 12:45
postmodern
postmodern requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things.

lib/ronin/recon/values/url.rb Outdated
def ===(other)
case other
when URL
uri == other.uri
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use @uri to avoid an extra method call.

spec/values/url_spec.rb Show resolved Hide resolved
@AI-Mozi AI-Mozi force-pushed the add_values_url_triple_equal branch from fa39a1e to 5d7ba4f Compare August 28, 2024 14:58
@postmodern postmodern merged commit fc4ba5b into ronin-rb:0.2.0 Aug 28, 2024
4 checks passed
@postmodern postmodern added this to the 0.2.0 milestone Aug 28, 2024
@postmodern postmodern added the feature New Feature label Aug 28, 2024
@postmodern postmodern mentioned this pull request Aug 28, 2024
Closed
@postmodern postmodern added the scope Scope Filtering label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern approved these changes

Assignees

@AI-Mozi AI-Mozi

Labels
feature New Feature scope Scope Filtering
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AI-Mozi @postmodern