Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web/screenshot recon worker #157

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Add web/screenshot recon worker #157

merged 1 commit into from
Aug 31, 2024

Conversation

AI-Mozi
Copy link
Member

@AI-Mozi AI-Mozi commented Aug 18, 2024

postmodern
postmodern requested changes Aug 18, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few minor things. Also probably need to improve Ronin::Web::Browser::Agent#screenshot to allow saving the screenshot into a root directory.

spec/builtin/web/screenshot.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/screenshot.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/screenshot.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/screenshot.rb Show resolved Hide resolved
lib/ronin/recon/builtin/web/screenshot.rb Show resolved Hide resolved
lib/ronin/recon/builtin/web/screenshot.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/screenshot.rb Outdated Show resolved Hide resolved
@AI-Mozi AI-Mozi force-pushed the add_web_screenshot_worker branch 5 times, most recently from a855a0d to 4ddea94 Compare August 27, 2024 14:11
postmodern
postmodern requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed two things. Also can configure WebMock to allow localhost requests for Ronin::Web::Browser.

lib/ronin/recon/builtin/web/screenshot.rb Show resolved Hide resolved
spec/builtin/web/screenshot_spec.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/screenshot.rb Outdated Show resolved Hide resolved
postmodern
postmodern requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to restrict the format param to just png and jpg.

lib/ronin/recon/builtin/web/screenshot.rb Outdated Show resolved Hide resolved
@postmodern postmodern added this to the 0.2.0 milestone Aug 31, 2024
@postmodern postmodern added the feature New Feature label Aug 31, 2024
@postmodern postmodern added the builtin Builtin Workers label Aug 31, 2024
@postmodern postmodern merged commit 6ba8fdb into ronin-rb:0.2.0 Aug 31, 2024
4 checks passed
@postmodern postmodern mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern approved these changes

Assignees

@AI-Mozi AI-Mozi

Labels
builtin Builtin Workers feature New Feature
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AI-Mozi @postmodern