added option to specify engines for executing tests, fixed casper integr... #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egration test, updated casperjs version to fix build issue
|
The new option key is unnecessary, you should just check if the options.casperjsOptions array has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope you find this pull request useful! I added a new "engines" option to the options field in the casperjs grunt task. This lets you specify either PhantomJS, SlimerJS, or both as targets. Leaving this option out will still execute the tests using PhantomJS as they did before, so it should be backwards compatible. I did add the engines option to the plugin's Gruntfile.js just to show the option, it isn't necessary, but I thought it was useful to include.
I also fixed the integration tests, they were still using options from the previous version of casperjs and would not work correctly. You should be able to run grunt from the command line now and see the test execute.
Let me know if anything doesn't look right in this PR and I can update it.