Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for productID in file name #445

Merged
merged 4 commits into from
Nov 5, 2023
Merged

Add check for productID in file name #445

merged 4 commits into from
Nov 5, 2023

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Nov 5, 2023 •
edited
Loading

In #350 it was clarified that sometimes the filename will contain the productID, and not the titleID.

  • Map the productID to the titleID during async task and save result to JSON file
  • Match against product ID format during scan/rescan
  • Less aggressive check for multiple file extensions

@gantoine gantoine requested a review from zurdi15 November 5, 2023 02:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023 •
edited
Loading

Test Results

69 tests   69 ✔️  17s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit a3a1eb9.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 merged commit 8b1dfaa into master Nov 5, 2023
2 checks passed
@zurdi15 zurdi15 deleted the romm-350-productid branch November 5, 2023 16:27
@KillahB33
Copy link

KillahB33 commented Nov 12, 2023 •
edited
Loading

Amazing! Thanks for the quick work all!!

Looks like I'm waiting for 2.2, let me know and I'll test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurdi15 zurdi15 zurdi15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gantoine @KillahB33 @zurdi15