Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover size standarization #442

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Cover size standarization #442

merged 4 commits into from
Nov 3, 2023

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Nov 3, 2023

This PR fixes the different sizes of IGDB covers, making them to have the same size in the gallery.

For small covers we keep the aspect ratio and for bigger covers RomM resizes them internally.

Before After

Fixes #340

@zurdi15 zurdi15 added the ui/ux UI/UX improvements or suggestions label Nov 3, 2023
@zurdi15 zurdi15 requested a review from gantoine November 3, 2023 16:09
@zurdi15 zurdi15 self-assigned this Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Test Results

69 tests  ±0   69 ✔️ ±0   20s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 11bec51. ± Comparison against base commit 7c9e273.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 merged commit 8ab68c1 into master Nov 3, 2023
5 checks passed
@zurdi15 zurdi15 deleted the fix-cover-sizes branch November 3, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux UI/UX improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants