Docker slim images #1406
Merged
Docker slim images #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantoine
force-pushed
the
docker-slim-images
branch
from
1f8c61c to
6fdc07a
Compare
gantoine
force-pushed
the
docker-slim-images
branch
from
6fdc07a to
7871533
Compare
Test Results91 tests 91 ✅ 26s ⏱️ Results for commit 252cbaa. ♻️ This comment has been updated with latest results. |
adamantike
reviewed
Jan 2, 2025
gantoine
force-pushed
the
docker-slim-images
branch
from
6a918ee to
44ab32c
Compare
adamantike
reviewed
Jan 4, 2025
adamantike
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aight let's break this down.
The github
buildaction now builds 2 images using different metadata tags and arguments. In theDockerfile, the image built withSLIM_IMAGE=falsewill fetch the emulatorjs and ruffle assets and copy them to the frontent/assets/.SLIM_IMAGEis also passed in at runtime from theDocekrfileas an env variable, and is used to determine, when loading the emulatorjs or ruffle players, whether to try fetching the libs/cores locally or from CDN.I've also refactored the
/heartbeatresponse to move all fields into categories, and remove no-longer-needed libs frompackage.json.