Mention ./gradlew jvmRun in the README #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is the preferred way to run it? (As opposed to downloading binaries?)
romainguy
requested changes
Jun 4, 2024
README.md
Outdated
| @@ -33,6 +33,8 @@ which panels are visible using the *View* menu. | |||
|
|
|||
| # Running Kotlin Explorer | |||
|
|
|||
| Kotlin Explorer is a Compose Desktop application. Run it with `./gradlew run`. | |||
There was a problem hiding this comment.
No need to mention it's a Compose Desktop application and ./gradlew run won't work. It's ./gradlew jvmRun and it needs the commit I just pushed.
There was a problem hiding this comment.
I swear I have ./gradlew run work with commit 10272421e8bdad56b01b6cdea2325ea6d170af7d. No idea why 🤷
I'll update to jvmRun
There was a problem hiding this comment.
On which OS? kotlin-explorer needs the JetBrains' runtime because of Jewel and its extensions, and a straight run will only work if your default JDK/JRE is a JetBrains one.
There was a problem hiding this comment.
I have MacOS and a jbrsdk:
$ echo $JAVA_HOME
/Library/Java/JavaVirtualMachines/jbrsdk-17.0.10-osx-aarch64-b1087.23/Contents/Home/
So that explains it 👍 . Text updated
martinbonnin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the preferred way to run it? (As opposed to downloading binaries?)
See also #52