Saves and Restores the Focus Owner Before and After a Dialog is Shown #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably related to `DialogSupportingSwingPanel` and sometimes causes a crash on Linux when: * Click in a code panel to set focus * Open Settings * Close Settings * Press any key I'm pretty sure this fixes it. I was able to repro very frequently before, and now I can't repro. That said, I was never able to get a 100% repro case.
romainguy
requested changes
May 7, 2024
src/jvmMain/kotlin/dev/romainguy/kotlin/explorer/DialogState.kt
Outdated
Show resolved
Hide resolved
romainguy
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably related to
DialogSupportingSwingPaneland sometimes causes a crash on Linux when:I'm pretty sure this fixes it. I was able to repro very frequently before, and now I can't repro.
That said, I was never able to get a 100% repro case.