Add a Progress Indicator #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainguy
requested changes
May 5, 2024
src/jvmMain/kotlin/dev/romainguy/kotlin/explorer/Disassembly.kt
Outdated
Show resolved
Hide resolved
|
Looks nice with the progress bar! |
I tried to add a popup dialog with a progress bar but I couldn't get the dialog to show. I added it to the status bar instead.
|
Any idea how to add a dialog? When I render a Dialog, nothing is displayed and the UI looks like some effect was done to it to reflect that it's behind something. |
|
I haven't tried dialogs in Compose for Desktop but I much prefer what you've done here. |
romainguy
approved these changes
May 6, 2024
romainguy
approved these changes
May 6, 2024
|
I'm resolving the conflicts. The Gradle cleanup removed too much. |
|
See #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add a popup dialog with a progress bar but I couldn't get the dialog to show. I added it to the status bar instead.