Add a Code Model

[alonalbert]

This makes it easier to detect jumps and toggle show-line-number

[romainguy]

Thanks! In addition to the comments I left, I noticed a huge difference in code formatting:

• Without line numbers the indentation is now 2 spaces, please keep the original, it's much more readable to me
• With line numbers on, the indentation is very wide (12 spaces??) with a lot of empty space around the line numbers. See screenshot

[alonalbert]

Regarding the indentations, I changed things up a bit.

Note that we have to account for long line numbers so:

class Foo
    <init>()V // Foo.<init>()
        1:    0000: invoke-direct {v0}, Ljava/lang/Object;.<init>:()V // method@0008
              0003: return-void

Might seem to sparse, but when line numbers get big:

    <init>()V // Foo.<init>()
        1000: 0000: invoke-direct {v0}, Ljava/lang/Object;.<init>:()V // method@0008
              0003: return-void

It makes sense.

I have a plan to use the max line number to derive the width, but will leave this to a future cl.

[alonalbert]

FYI, the OAT parser has a bug in ti. Infinte loop sometimes
I'm investigating

[alonalbert]

OK, fixed it.

[romainguy]

Note that we have to account for long line numbers so

That's what I thought. Have you tried eating up into the left indent instead? I don't know how pretty it would look but something like this:

class Foo
    <init>()V // Foo.<init>()
1:      0000: invoke-direct {v0}, Ljava/lang/Object;.<init>:()V // method@0008
        0003: return-void
    <bar>()V // Foo.<init>()
1000:   0000: invoke-direct {v0}, Ljava/lang/Object;.<init>:()V // method@0008
        0003: return-void