Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Simplify Splitter Related Code #21

Merged
merged 1 commit into from
May 2, 2024
Merged

[Refactor] Simplify Splitter Related Code #21

merged 1 commit into from
May 2, 2024

Conversation

alonalbert
Copy link
Contributor

  • Don't use a mutableStateOf for the RSyntaxTextArea.
  • Extract code creating the various RSyntaxTextArea components to methods
  • Extract the code for creating the text areas Composables to methods
  • Extract a 3-way splitter method
  • Add a DocumentListener that takes a single lambda

@alonalbert
[Refactor] Simplify Splitter Related Code
b40cc5e 
* Don't use a mutableStateOf for the RSyntaxTextArea.
* Extract code creating the various RSyntaxTextArea components to methods
* Extract the code for creating the text areas Composables to methods
* Extract a 3-way splitter method
* Add a DocumentListener that takes a single lambda
@romainguy romainguy merged commit 7491c9f into romainguy:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainguy romainguy romainguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alonalbert @romainguy