Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Overview Section and Fix Image Visibility in Performance Metrics [Fixed #196] #198

Merged
merged 10 commits into from
Oct 31, 2024

Conversation

Karthik3904
Copy link
Contributor

@Karthik3904 Karthik3904 commented Oct 28, 2024

closes #196

Description

This pull request addresses two improvements:

  1. Updated the Overview Section: Enhanced the "Overview" section to provide more clarity about the project's purpose, data source, and objectives. This update makes it easier for users to understand the goal and scope of the project. The new content includes a detailed explanation of the project’s focus on predicting stock prices for the State Bank of India (SBI) using machine learning regression algorithms.

  2. Fixed Image Visibility in Performance Metrics: Corrected the broken image links in the "Performance Metrics" section. The images for Root Mean Square Error (RMSE), Mean Absolute Error (MAE), and Mean Absolute Percentage Error (MAPE) are now visible, displaying the performance metrics for the 10 regression algorithms.

This PR enhances the readability and presentation of the documentation, providing a better user experience.

Screenshots of the changes have been included
Screenshot 2024-10-27 134912
Screenshot 2024-10-27 134927
Screenshot 2024-10-27 134944
Screenshot 2024-10-27 134952

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Mayureshd-18 Mayureshd-18 self-requested a review October 28, 2024 17:28
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karthik3904

  1. Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here:
    https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

  2. Please reduce the size of images.

@Karthik3904
Copy link
Contributor Author

I made the following changes. Please accept my PR and merge it. Thank you for your valuable time

@Mayureshd-18 Mayureshd-18 self-requested a review October 29, 2024 14:27
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mayureshd-18 Mayureshd-18 added gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 level1 10 Points 🥇(GSSoC) hacktoberfest Hacktober Collaboration labels Oct 29, 2024
Copy link
Owner

@rohitinu6 rohitinu6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karthik3904 I believe you are not using the updated version of this repo in your code:
image

That is also the reason why the very first image in the readme file, which is the screenshot of the webpage does not match with the latest version of the repo

I would suggest you to sync fork and make all the updates

@Karthik3904
Copy link
Contributor Author

I Synced and updated my repo

Screenshot 2024-10-30 083603

@rohitinu6 rohitinu6 merged commit 26102cb into rohitinu6:main Oct 31, 2024
2 of 3 checks passed
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #198 has been merged! 🎉🎉

@Karthik3904
Copy link
Contributor Author

Thank You. Happy Diwali🎉💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 level1 10 Points 🥇(GSSoC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Overview Section and Fix Image Visibility in Performance Metrics
3 participants