-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Overview Section and Fix Image Visibility in Performance Metrics [Fixed #196] #198
Update Overview Section and Fix Image Visibility in Performance Metrics [Fixed #196] #198
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword -
Please reduce the size of images.
I made the following changes. Please accept my PR and merge it. Thank you for your valuable time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Karthik3904 I believe you are not using the updated version of this repo in your code:
That is also the reason why the very first image in the readme file, which is the screenshot of the webpage does not match with the latest version of the repo
I would suggest you to sync fork and make all the updates
🎉🎉 Thank you for your contribution! Your PR #198 has been merged! 🎉🎉 |
Thank You. Happy Diwali🎉💥 |
closes #196
Description
This pull request addresses two improvements:
Updated the Overview Section: Enhanced the "Overview" section to provide more clarity about the project's purpose, data source, and objectives. This update makes it easier for users to understand the goal and scope of the project. The new content includes a detailed explanation of the project’s focus on predicting stock prices for the State Bank of India (SBI) using machine learning regression algorithms.
Fixed Image Visibility in Performance Metrics: Corrected the broken image links in the "Performance Metrics" section. The images for Root Mean Square Error (RMSE), Mean Absolute Error (MAE), and Mean Absolute Percentage Error (MAPE) are now visible, displaying the performance metrics for the 10 regression algorithms.
This PR enhances the readability and presentation of the documentation, providing a better user experience.
Screenshots of the changes have been included