Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecation warnings of input_length argument and HDF5 format of model saving #197

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

shristirwt
Copy link
Contributor

@shristirwt shristirwt commented Oct 27, 2024

Issue Reference: Fixes #193

Description of changes: I updated the code to remove deprecation warnings of input_length argument and HDF5 format of model saving

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Mayureshd-18 Mayureshd-18 self-requested a review October 27, 2024 18:03
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

If needed, please check out merged PRs for reference.

Thanks & regards

@shristirwt
Copy link
Contributor Author

I have made the changes

@jvedsaqib jvedsaqib requested a review from rohitinu6 October 28, 2024 14:23
@Mayureshd-18 Mayureshd-18 self-requested a review October 28, 2024 17:27
@Mayureshd-18 Mayureshd-18 added gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 level1 10 Points 🥇(GSSoC) hacktoberfest Hacktober Collaboration labels Oct 28, 2024
@Mayureshd-18 Mayureshd-18 merged commit 5794a6a into rohitinu6:main Oct 28, 2024
5 checks passed
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #197 has been merged! 🎉🎉

@shristirwt shristirwt deleted the local branch October 29, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 level1 10 Points 🥇(GSSoC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Deprecation Warnings: input_length Argument in Embedding Layer and HDF5 Format for Model Saving
3 participants