-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysed data and created Dashboard using Tableau #190
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the PR matches the requirements mentioned in the Contribution guide. The maintainer might get in touch to enusre quality. Thanks for your time
@manikjain105 Is it specific for SBI stock only? |
Yes , it is based according to the dataset sbin.csv |
@manikjain105 Please make the dashboard insightful; your work only shows a candlestick chart. |
@rohitinu6 I have done the required changes.. Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have synced as requested , kindly check |
@jvedsaqib @rohitinu6 Can you please review it and confirm if any procedures is left to be done from my side in order to get my pr merged |
@jvedsaqib can you please review and merge the pr |
🎉🎉 Thank you for your contribution! Your PR #190 has been merged! 🎉🎉 |
Issue Reference:
Closes #133
Description of Changes:
Closes #133