Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stock-Sentimental issues #145 closes #145 #164

Merged
merged 3 commits into from
Oct 25, 2024
Merged

stock-Sentimental issues #145 closes #145 #164

merged 3 commits into from
Oct 25, 2024

Conversation

sapnilmodak
Copy link
Contributor

@sapnilmodak sapnilmodak commented Oct 22, 2024 •
edited
Loading

Issue Reference:
Closes #145

Description of changes: #145

@github-actions GitHub Actions
Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sapnilmodak
Copy link
Contributor Author

closes #145

@Mayureshd-18 Mayureshd-18 self-requested a review October 22, 2024 11:50
Mayureshd-18
Mayureshd-18 requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sapnilmodak Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

If needed, please check out merged PRs for reference.

Thanks & regards

@sapnilmodak
Copy link
Contributor Author

@Mayureshd-18 I have linked issue with closes

@Mayureshd-18
Copy link
Collaborator

@Mayureshd-18 I have linked issue with closes

Until the issue is seen on the 'Pull requests' page, its not linked correctly. Please refer to merged PRs for reference.

@sapnilmodak
Copy link
Contributor Author

@Mayureshd-18 is it perfect now?

@sapnilmodak
Copy link
Contributor Author

fixes #145

@sapnilmodak sapnilmodak changed the title stock-Sentimental issues #145 Closes #145 stock-Sentimental issues #145 closes #145 Oct 22, 2024
@sapnilmodak
Copy link
Contributor Author

@Mayureshd-18 please check now?

Mayureshd-18
Mayureshd-18 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mayureshd-18 Mayureshd-18 added gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 hacktoberfest Hacktober Collaboration level2 25 Points 🥈(GSSoC) labels Oct 23, 2024
@sapnilmodak
Copy link
Contributor Author

commit the changes @rohitinu6

@rohitinu6 rohitinu6 merged commit abbd51a into rohitinu6:main Oct 25, 2024
4 of 9 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #164 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitinu6 rohitinu6 rohitinu6 approved these changes

@jvedsaqib jvedsaqib jvedsaqib approved these changes

@Mayureshd-18 Mayureshd-18 Mayureshd-18 approved these changes

Assignees

@sapnilmodak sapnilmodak

Labels
gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 level2 25 Points 🥈(GSSoC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] <description>Enhancing Stock Prediction Accuracy Using Stock Sentiment Analysis
4 participants
@sapnilmodak @Mayureshd-18 @jvedsaqib @rohitinu6