Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magicbot: Add tunable update listener method #136

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

magicbot: Add tunable update listener method #136

wants to merge 4 commits into from

Conversation

auscompgeek
Copy link
Member

This adds a way to add a callback for NT updates to tunables.

Ref: #133

@auscompgeek
magicbot: Add tunable update listener method
af0809a 
This adds a way to add a callback for NT updates to tunables.
virtuald
virtuald reviewed Feb 28, 2019
View reviewed changes
Copy link
Member

@virtuald virtuald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One objection I have with this implementation is adding an additional entry listener. As you add more of them it'll keep making callbacks more expensive (which is a problem with the current ntcore implementation... ).

magicbot/magic_tunable.py Show resolved Hide resolved
magicbot/magic_tunable.py Outdated Show resolved Hide resolved
@auscompgeek
Copy link
Member Author

@virtuald Now that we have pyntcore, do you still have objections to this?

@virtuald
Copy link
Member

Callbacks still have the same issue.

@auscompgeek auscompgeek marked this pull request as draft July 23, 2020 06:39
@auscompgeek auscompgeek added the magicbot magicbot package label Aug 16, 2020
Base automatically changed from master to main January 14, 2021 07:35
@virtuald virtuald mentioned this pull request Jan 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virtuald virtuald virtuald left review comments

Assignees
No one assigned
Labels
magicbot magicbot package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auscompgeek @virtuald